Mmm.. I could use pgrp==0 if that works here.. ?

I don't know if 0 will work, it might need to match player's pgrp if player has ttyS1 for std*

i'll try when I get home

Okeydoeky. Also, I just noticed that stdin == /dev/null already for EXECs.

Cheers

Hate to interrupt a good hacking discussion, but I hadn't received a "yay" or "nay" as to whether this patch is okay for inclusion in Hijack. It allows user apps to (a) get a copy of the player's screenbuf and (b) get the UI flags status. I will be making extensive use of these for my next release, and I think they're good things to have available. Any thoughts?

In fact, pgrp = 0, still "failed to set up serial port".

Fine, you win. Here's a patch to disable the pgrp check. Tested: it works.

Rather than breaking telnetd and friends, how about the attached patch?

patch war?

Sure. It looks like a different ugly patch

Let me ask this: why does the player get ttyS1 as std(in,out,err) when I've selected "apps" and not "player" for the serial port? Because fundamentally I think fixing that is the answer, but I'm fuzzy on *why* it's happening, because I think I haven't found the right place to look yet.

Man, I go away from the BBS for a day and come back, and my tiny little bug report has sparked this whole complicated thing.

Cool.

The player, when started up (by init, presumably), is given /dev/console for stdin/stdout/stderr. It later then opens /dev/ttyS1 for serial port control notify and control features.

When "apps use serial port" is selected, Hijack intercepts the startup of the player, and appends an option flag that tells the player to not open /dev/ttyS1 for serial port control and notify. Regardless, it still already has /dev/console.

On the Empeg, /dev/console is mapped to the serial port. Which confused the heck out of me the first time I looked there when writing the original Hijack code that intercepts the notify info and makes it available under /proc/empeg_notify --> the serial output from the player arrives in two distinct streams, from two logical devices, all heading to the same serial port.

Cheers

I feel silly now. /dev/console mapping to ttyS1 was something I thought of, and then forgot. Doh.

Hijack v364 has this fix in it (untested by me).

Cheers

I tried Hijack 365 and still get "Failed to set up serial port".

Did we also need a new GPSapp, or just the change in Hijack?

If we need a new GPSapp, would this one suffice, or do we need those changes as well as additional ones?

I didn't test it yet either. I see Tony says not. I'll see later what the deal is.

Naw, my bug.

I'll fix it shortly.

Cheers

You already know what's wrong then?

I'm in an interview now so I can't look.

Okay, try this one.

Cheers

Okay, try this one.

Since there was no attachment, I assume you mean v366 at the web site. Grabbed it, tried it.

Good= I don't get the "failed to set up serial port" error.

Bad= GPS doesn't work.

If it's in the home sled (no GPS attached) and I use force-DC mode to make GPSapp available, the GPSapp program locks up with a black screen when I invoke it.

If it's in the car sled (GPS actually attached), it sits there at "Waiting for data from GPS receiver" but never gets past it.

I will concede that it's possible my GPS unit failed sometime between yesterday (last time I used GPSapp) and today, but I'm betting it's not a likely enough possibility that warrants me putting an older hijack back into place and doing another run out to the car again.

This would be a different gpsapp issue, then. Also, don't use v3alpha for this -- something about serial has changed in v3 as well.

-ml

I've been using 2.0 final for this, but thanks for checking.

/me goes back to Hijack v354 so he can continue to use GPSapp...

I was using v3 alpha6, and a real gps receiver, and that gpsapp binary that I posted, and the first patch (the one that doesn't change pgrp) and telnetd worked, and gpsapp saw satellites, and I got music.

What problem should I have had?

Geez, that reads really snide, and I didn't mean it that way.

But seriously, is there some problem I should be looking for/at?

I dunno. Tony??

The patch in Hijack is somewhat different than that I posted here, but should be even less restrictive. Tony said no issues with serial port messages, at least, but beyond that.. dunno.

But seriously, is there some problem I should be looking for/at?

My problem is that when I run any version of Hijack later than the one I posted above (what was it, 360?), I can't use GPSapp because gpsapp either says "failed to set up serial port" or it locks up completely.

Yeah, but I said "with the patch I posted", and that was alpha 6, post 360, modern gpsapp. I was asking Mark what problem he saw.

I'll look at diffs, I guess.

I don't see any problem. The patch I actually applied should achieve the same behaviour, but without impacting the behaviour of background processes that are not using /dev/ttyS1.

Cheers

Yeah, but I said "with the patch I posted",

Oh, sorry.